Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new_writing <- main #16

Merged
merged 69 commits into from
Apr 1, 2024
Merged

new_writing <- main #16

merged 69 commits into from
Apr 1, 2024

Conversation

alanmmckay
Copy link
Owner

Bringing new_writing up to speed.

…lementing piecemeal loading of images triggered by positional scrolling. The images being loaded will act as a buffer beyond th images that are loaded in but hidden via the opacity attribute.
…y investigating why the display method is kicking prematurely.
…dition which determines whether or not a figure is at the correct position.
…age heights with respect to the columns as they are loaded in.
…ere is a logical error where one of the columns loses steam. Created a new branch for this because the algorithm currently loads in three images for each singular image load. I would like to make this more effecient but unsure whether or not I want to save the progress of this commit to the originating branch.
…in place. In the process of fixing logical errors contained in the last loop of this funciton; iirc things are working correctly but I want to validate this still
…es concurrently/through an async funciton whilst the current active grid is being populated. This requires bucketing values associated with the grid, and perhaps the manifest itself. Will need to refactor code within the grid loader.
…dded a col_maps collection to house information for each column mapping
… they work in handling grids of varying columns. Need to dry out some code pertaining to setting up the initial variables handling the grid and manifest objects. Currently working on logic to swithc from one view to another.
…for tracking the height of objects that are hidden. This is what was leveraged to allow all the views to run the logic in place for the grid agents.
…actored information pertaining to global variable collections.
…es of images are loaded in on page load is back. Unsure if this is because I'm currently developing on a different device. I'll have to revert back to the prior commit and test this device on it to see what's up.
image_gallery <- image_gallery_balanced_load
…ine the maximum amount of columns on a page; this will prevent extraneous calculations within the mobile environment.
… to a .js file which simply sets the manifest global variable to the json structure required. There is also an update to the manifest proper as it was previously setting empty arrays to the images that were recently ommitted.
…d meta information to the page in addition to bot crawl prevention.
…opacity filter is now dependent on how large the column is with respect to the screen size.
…of zero. Still considering how to solve the issue where a column readjustment requires a reload of images (rather - the column views haven't received a call to grid_load_agent yet on account of the fact is_figure_bottom hasn't returned a true for these items yet.)
…nt was essentially the same as load_counts. Removed a lot of the commented console.logs which were previously used for debugging. Other extraneous comment cleanup.
general_edits <- image_gallery
…ld javascript be enabled. This was an attempt of enforcing more granular lazy load behavior. Still needs some work on this front.
… it contains is completely loaded. This was accomplished by using lambdas and data atributes within the html elemnnts themselves.
…Cleaned up create_image function in terms of parameter naming. There seems to be one image that isn't being covered by grid_load_agent. Need to look more closely at how the loop is seting its boundaries.
…e the loading-images message is unaffected by edge case discussed in a recent commit message.
… are displayed at the bottom of the gallery.
@alanmmckay alanmmckay merged commit b6c7674 into new_writing Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant